c - Pass unsigned char pointer to atoi without cast -

-

on embedded device, have passed unsigned char pointer atoi without cast.

unsigned char c[10]="12"; atoi(c);

question: defined?

i saw somewhere ok string functions, not sure atoi.

edit: btw. concerns have been expressed on 1 of answer below might not ok string functions such strcpy - if got right (?) author meant can in practice can ok.

also here, ok following assignment unsigned char pointer ok too? because used tool complaining "type mismatch (assignment) (ptrs signed/unsigned)"

unsigned char *ptr = strtok(unscharbuff,"-");     // assignment ok unsigned char?

no, it's not defined. it's constraint violation, requiring compile-time diagnostic. in practice it's very work expect, it's not guaranteed so, , imho it's poor style.

the atoi function declared in <stdlib.h> as:

int atoi(const char *nptr);

you're passing unsigned char* argument function expects char* argument. 2 types not compatible, , there no implicit conversion 1 other. conforming compiler may issue warning (that counts diagnostic) , proceed generate executable, behavior of executable undefined.

as of c99, call function no visible declaration constraint violation, can't away omitting #include <stdlib.h>.

c still permit calls functions visible declaration declaration not prototype (i.e., doesn't define number of type(s) of parameters). so, rather usual #include <stdlib.h>, add own declaration:

int atoi();

which permit calling unsigned char* argument.

this "work", , might possible construct argument standard behavior defined. char , unsigned char values of '1' , '2' guaranteed have same representation

but it's far easier add cast prove it's not necessary -- or, better yet, define c array of char rather array of unsigned char, since it's intended hold string.

unsigned char *ptr = strtok(unscharbuff,"-");

this constraint violation. there no implicit conversion unsigned char* char* first argument in strtok call, , there no implicit conversion char* unsigned char* initialization of ptr.


Comments

Post a Comment

Popular posts from this blog

Java 3D LWJGL collision -

-
i making 3d java game lwjgl library, , wondering how add collision detection, player not go through models. i using obj models. here objloader class, loads models: package renderengine; import java.io.bufferedreader; import java.io.file; import java.io.filenotfoundexception; import java.io.filereader; import java.util.arraylist; import java.util.list; import models.rawmodel; import org.lwjgl.util.vector.vector2f; import org.lwjgl.util.vector.vector3f; public class objloader { public static rawmodel loadobjmodel(string filename, loader loader){ filereader fr = null; try { fr = new filereader(new file("res/"+filename+".obj")); } catch (filenotfoundexception e) { system.err.println("couldn't load file!"); e.printstacktrace(); } bufferedreader reader = new bufferedreader(fr); string line; list<vector3f> vertices = new arraylist<vector3f...
Read more

methods - python can't use function in submodule -

-
my folder structure this: pythonstuff/ program.py modulea/ __init__.py foo.py bar.py here's code bar.py : def hello(): print("hello, world!") here's code program.py : #!/usr/bin/env python3 modulea import bar bar.hello() i run $ python3 program.py somehow error: file "program.py", line 3, in <module> bar.hello() attributeerror: 'module' object has no attribute 'hello' edit: __init__.py file empty. edit2: after trying realized had bar.py in root directory contained hello() method. bar.py in modulea/ directory empty. add it import os __all__ = [] module in os.listdir(os.path.dirname(__file__)): if module != '__init__.py' , module[-3:] == '.py': __all__.append(module[:-3]) the init .py files required make python treat directories containing packages; done prevent directories common name, such string, unintentionally hiding v...
Read more

c# - ErrorThe type or namespace name 'AxWMPLib' could not be found (are you missing a using directive or an assembly reference?) -

-
what possible reference handler axwmplib._wmpocxevents_playstatechangeeventhandler ? when pass event in method, private void axwindowsmediaplayer1_playstatechange(object sender,axwmplib._wmpocxevents_playstatechangeevent e) compiling throws following error: the type or namespace name 'axwmplib' not found (are missing using directive or assembly reference?) if using visual studio make sure have axwmplib listed under references in solution explorer. if have embedded windows media player control in form, should have been added automatically along wmplib . an easy way add these libraries if missing add windows media player control form (an existing 1 do). right-click on toolbox , pick "choose items..." context menu, tick "windows media player" control on "com components" tab , click ok. should have little windows media player icon attached cursor; click on form add it. add axwmplib , wmplib references solution. can delete w...
Read more